[
https://issues.apache.org/jira/browse/SHIRO-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361031#comment-15361031
]
ASF GitHub Bot commented on SHIRO-480:
--------------------------------------
GitHub user ankon opened a pull request:
https://github.com/apache/shiro/pull/22
SHIRO-480: Remove the wrong assignment to this.targets
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Collaborne/shiro issue/SHIRO-480
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/shiro/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
----
commit 546de0b7bfa41047c96ec5b8f7dbe0da671ceae6
Author: Andreas Kohn <[email protected]>
Date: 2015-10-09T10:03:14Z
SHIRO-480: Remove the wrong assignment to this.targets
----
> setTarget method in DomainPermission does not set targets
> ---------------------------------------------------------
>
> Key: SHIRO-480
> URL: https://issues.apache.org/jira/browse/SHIRO-480
> Project: Shiro
> Issue Type: Bug
> Components: Authorization (access control)
> Affects Versions: 1.2.2
> Reporter: Bill Weiss
> Priority: Minor
>
> The setTarget() method in org.apache.shiro.authz.permission.DomainPermission
> has an apparent typo, or copy paste error:
> 133 protected void setTargets(Set<String> targets) {
> 134 this.targets = targets;
> 135 if (this.targets != null && this.targets.equals(targets)) {
> 136 return;
> 137 }
> 138 this.targets = targets;
> 139 setParts(domain, actions, targets);
> 140 }
> As you can see, line 134 is a duplicate of line 138 and will in all cases,
> except where the argument targets is null, prevent execution from ever
> calling setParts() and functioning properly.
> The work around for now is for classes extending DomainPermission to handle
> the call to setParts() directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
