Thanks François! +1
On Tue, Apr 30, 2019 at 1:43 PM Francois Papon <[email protected]> wrote: > Hi Brian, > > Thanks for catching this! > > You're right, I forgot to tag the vote and it's ok now: > > > https://github.com/apache/shiro/compare/master...shiro-root-1.4.1-release-vote1 > > regards, > > François Papon > [email protected] > > Le 30/04/2019 à 18:58, Brian Demers a écrit : > > I'm -1, due to the fact the tag isn't available for inspection (I'm sure > > I've done this too). > > That said I took a look at where master is now compared to 1.4.0 and > there > > are no surprises, I've also run the staged build through a couple of > > projects without issue. > > > > I suggest the tag is pushed as `shiro-root-1.4.1-release-vote1` and the > > vote stay open for another 72 hours. > > (I'll also change my vote to an affirmative after that) > > > > Also, sorry about being late to the party, I was out of contact last > week. > > > > > > Note: I could just be missing something if the tag is available and > > I'm just not seeing it ;) > > > > > > On Thu, Apr 25, 2019 at 2:38 PM Francois Papon < > [email protected]> > > wrote: > > > >> Hi guys, > >> > >> We need one more +1 binding vote :) > >> > >> regards, > >> > >> François Papon > >> [email protected] > >> > >> Le 24/04/2019 à 23:40, Les Hazlewood a écrit : > >>> +1 (binding) > >>> > >>> On Wed, Apr 24, 2019 at 2:11 PM Francois Papon < > >> [email protected]> > >>> wrote: > >>> > >>>> Here my +1 (binding) > >>>> > >>>> François Papon > >>>> [email protected] > >>>> > >>>> Le 19/04/2019 à 09:34, [email protected] a écrit : > >>>>> Hi all, > >>>>> > >>>>> I submit Apache Shiro 1.4.1 to your vote. This is a > >>>>> maintenance release on the 1.4.x series, bringing some improvements > and > >>>>> bug fixes (with a special work on OSGi). > >>>>> > >>>>> Release Notes: > >>>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310950&version=12344826 > >>>>> Staging Repository: > >>>>> > https://repository.apache.org/content/repositories/orgapacheshiro-1021 > >>>>> > >>>>> Git Tag: > >>>>> shiro-1.4.1 > >>>>> > >>>>> |Project website (just ||for| |informational purposes, not to be > voted > >>>>> upon):| > >>>>> |https:||//shiro.apache.org/| <http://shiro.apache.org/%7C> < > http://shiro.apache.org/%7C> < > >> http://shiro.apache.org/%7C> < > >>>> https://shiro.apache.org/> > >>>>> |Guide to testing staged releases:| > >>>>> |https:||// > >>>> maven.apache.org/guides/development/guide-testing-releases.html| > <http://maven.apache.org/guides/development/guide-testing-releases.html%7C> > >> < > http://maven.apache.org/guides/development/guide-testing-releases.html%7C> > >>>> < > >> > http://maven.apache.org/guides/development/guide-testing-releases.html%7C> > >>>>> < > >> https://maven.apache.org/guides/development/guide-testing-releases.html > >>>>> > >>>>> Please vote to approve this release: > >>>>> > >>>>> [ ] +1 Approve the release > >>>>> [ ] -1 Don't approve the release (please provide specific comments) > >>>>> > >>>>> This vote will be open for at least 72 hours. > >>>>> >
