fpapon commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530351620 @boris-petrov Hi! we have the `japicmp` maven plugin failed on the build because of backward incompatibility: ``` [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.14.1:cmp (japicmp) on project shiro-web: There is at least one incompatibility: org.apache.shiro.web.servlet.Cookie.getSameSite():METHOD_ADDED_TO_INTERFACE,org.apache.shiro.web.servlet.Cookie.setSameSite(org.apache.shiro.web.servlet.Cookie$SameSiteOptions):METHOD_ADDED_TO_INTERFACE,org.apache.shiro.web.servlet.SimpleCookie.buildHeaderValue(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,int,int,boolean,boolean):METHOD_REMOVED ``` I think it's better to add a new method instead of update the existing one. @bdemers Thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
