[
https://issues.apache.org/jira/browse/SHIRO-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057324#comment-17057324
]
Brian Demers commented on SHIRO-747:
------------------------------------
Thanks [~twbecker],
That was helpful! I've created a PR for this:
https://github.com/apache/shiro/pull/203
> FirstSuccessfulStrategy doesn't properly short circuit
> ------------------------------------------------------
>
> Key: SHIRO-747
> URL: https://issues.apache.org/jira/browse/SHIRO-747
> Project: Shiro
> Issue Type: Bug
> Affects Versions: 1.5.1
> Reporter: Tommy Becker
> Priority: Major
>
> SHIRO-669 supposedly added a method to skip subsequent authentications if one
> had already succeeded. But it doesn't work; it conditions throwing the
> ShortCircuitIterationException in beforeAttempt() in part on the
> PrincipalCollection being empty, which it will (properly) not be if an
> authentication has succeeded. I believe the check should be that the it is
> *not* empty. Was this tested??
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
