bmhm commented on issue #209: [SHIRO-530] INI parser does not properly handled 
backslashes at end o…
URL: https://github.com/apache/shiro/pull/209#issuecomment-606412522
 
 
   > As for `"Truth\\=Beauty"`, I would _expect_ that that to be some sort of 
error or at least a key with no value similar to:
   
   Thanks for the input @bdemers, I had the very same thoughts! The new 
force-pushed commit:
   
     * Will throw an IllegalArgumentException for `Key\\=Value`.
     * Will (as before!) remove all backslashes from the key.
     * Will *not* (new behaviour) remove any backslashes from the value. The 
continuation backslash not included.
   
   Actually, what @fpapon pointed out by posting the link: The XML config DOES 
allow backslashes in the key, where the Ini never allowed to do so. Please 
review my new commit which reflects these changes. I moved the tests a bit and 
commented them, so we can see what would change.
   Please keep in mind: Neither the current nor the desired/expected behaviour 
is currently documented, not even in the code! It is *just* the tests!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to