[GitHub] [singa] Wentong-DST commented on issue #552: SINGA-496 Implement softplus and softsign functions for tensor math

[GitBox]

Wentong-DST commented on issue #552: SINGA-496 Implement softplus and softsign 
functions for tensor math
URL: https://github.com/apache/singa/pull/552#issuecomment-553999136
 
 
   Hi @chrishkchris , I have added code as suggested, however, I still observe 
some errors while running tests. 
   So I paste logs here, please advise, thanks!
   ```
   [ 98%] Building CXX object 
test/CMakeFiles/test_singa.dir/singa/test_tensor_math.cc.o
   [ 99%] Building CXX object 
test/CMakeFiles/test_singa.dir/singa/test_textfile_rw.cc.o
   [100%] Building CXX object 
test/CMakeFiles/test_singa.dir/singa/test_timer.cc.o
   /content/incubator-singa/test/singa/test_tensor_math.cc: In member function 
‘virtual void TensorMath_SoftPlusCpp_Test::TestBody()’:
   /content/incubator-singa/test/singa/test_tensor_math.cc:130:14: error: 
‘SoftPlus’ was not declared in this scope
      Tensor p = SoftPlus(cc);
                 ^~~~~~~~
   /content/incubator-singa/test/singa/test_tensor_math.cc: In member function 
‘virtual void TensorMath_SoftSignCpp_Test::TestBody()’:
   /content/incubator-singa/test/singa/test_tensor_math.cc:143:14: error: 
‘SoftSign’ was not declared in this scope
      Tensor p = SoftSign(cc);
                 ^~~~~~~~
   /content/incubator-singa/test/singa/test_tensor_math.cc:143:14: note: 
suggested alternative: ‘copysign’
      Tensor p = SoftSign(cc);
                 ^~~~~~~~
                 copysign
   /content/incubator-singa/test/singa/test_tensor_math.cc: In member function 
‘virtual void TensorMath_SoftPlusCuda_Test::TestBody()’:
   /content/incubator-singa/test/singa/test_tensor_math.cc:1238:12: error: 
‘SoftPlus’ was not declared in this scope
      auto y = SoftPlus(x);
               ^~~~~~~~
   /content/incubator-singa/test/singa/test_tensor_math.cc:1242:30: error: 
expected primary-expression before ‘float’
      const float *dptr = y.data<float>();
                                 ^~~~~
   /content/incubator-singa/test/singa/test_tensor_math.cc: In member function 
‘virtual void TensorMath_SoftSignCuda_Test::TestBody()’:
   /content/incubator-singa/test/singa/test_tensor_math.cc:1253:12: error: 
‘SoftSign’ was not declared in this scope
      auto y = SoftSign(x);
               ^~~~~~~~
   /content/incubator-singa/test/singa/test_tensor_math.cc:1253:12: note: 
suggested alternative: ‘copysign’
      auto y = SoftSign(x);
               ^~~~~~~~
               copysign
   /content/incubator-singa/test/singa/test_tensor_math.cc:1257:30: error: 
expected primary-expression before ‘float’
      const float *dptr = y.data<float>();
                                 ^~~~~
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services