dcslin commented on issue #639: added support for matmul 3d 4d URL: https://github.com/apache/singa/pull/639#issuecomment-605794131 > Is it called batched matmul or batched gemm? > Seems different to tensordot. > since the API for matmul remains the same, we may need to update the DocString. In the high level API, `batch matmul` is ok, I see people calling it this way. In numpy, all `matmul` are call `matmul`. In the low level API, cublas calls it `Batched GEMM`, cblas also does similarly. I have update `singa/tensor.py` docstring to cover 3 cases: 1. 2d*1d matrix to vector 2. 2d*2d matrix to matrix 3. 3/4d*3/4d batched matrix to matrix
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services