dcslin commented on issue #696: URL: https://github.com/apache/singa/issues/696#issuecomment-628547912
To me this api is more clear. For example, the `model.compile([x])` make more sense as it require `x` as arg, compared to `model([x])`. Also introducing `train_one_batch()` gives flexibility on loss function and optim function. While `train_one_batch()` is only an interface, and let user to define, and there is no decorator for this method. It sounds like there is no enforcement for user to use this method. Maybe we can make it clear in documentation that this is singa-way to build the model to enforece this `train_one_batch()` method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
