moazreyad commented on code in PR #1383: URL: https://github.com/apache/singa/pull/1383#discussion_r3522919345
########## examples/singa_peft/examples/data/download_mnist.py: ########## @@ -0,0 +1,49 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +import os +import urllib.request + + +def check_exist_or_download(url): + + download_dir = '/tmp/' # downloaded to the /tmp/ folder + name = url.rsplit('/', 1)[-1] + filename = os.path.join(download_dir, name) + + if not os.path.isfile(filename): + print("Downloading %s" % url) + urllib.request.urlretrieve(url, filename) + else: + print("Already Downloaded: %s" % url) Review Comment: ### Suggestion: improve download logging clarity The current download log is helpful, but it would be even better if we also print the resolved local path (or target directory) where files are stored. This makes it easier to debug storage issues and verify where artifacts end up, especially since the download location may depend on defaults or environment variables (e.g. `/tmp/mnist`). In addition, it would improve clarity to include the local filename/path in both download states. #### Proposed changes: ```python if not os.path.isfile(filename): print("Downloading %s -> %s" % (url, filename)) urllib.request.urlretrieve(url, filename) else: print("Already Downloaded: %s -> %s" % (url, filename)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
