moazreyad commented on PR #1389: URL: https://github.com/apache/singa/pull/1389#issuecomment-4886290037
Closing this PR because it removes `examples/msmlp/model.py`, which is still referenced by four existing model-selection paths: 1. `examples/cnn_ms/train_cnn.py` (lines 339–347) 2. `examples/cnn_ms/train_ms_model.py` (lines 332–340) 3. `examples/model_selection/Trails/internal/ml/model_selection/src/eva_engine/phase1/algo/singa_ms/cnn_ms/train_cnn.py` (lines 344–352) 4. `examples/model_selection/Trails/internal/ml/model_selection/src/eva_engine/phase1/algo/singa_ms/cnn_ms/train_ms_model.py` (lines 345–353) Each of these paths handles the `msmlp` CLI option by importing: ```python from msmlp import model model = model.create_model(...) ``` The argument parsers also still advertise `msmlp` as a valid model choice. As a result, removing `examples/msmlp/model.py` causes the `msmlp` option to fail at import time because `msmlp.model` no longer exists. For this reason, I'm closing the PR without merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
