moazreyad commented on code in PR #1381:
URL: https://github.com/apache/singa/pull/1381#discussion_r3531780621


##########
.asf.yaml:
##########
@@ -24,3 +24,16 @@ github:
     wiki: true
     # Enable issues on github
     issues: true
+  rulesets:

Review Comment:
   The proposed default-branch protection looks appropriate for SINGA.
   
   Protecting the default and release branches from deletion and force pushes 
is consistent with our normal pull-request workflow. The `release/*` and 
`rel/*` patterns provide sensible coverage and can be revisited if the project 
adopts a different naming convention.
   
   +1 to merge. If no one objects, we can proceed and merge it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to