moazreyad opened a new pull request, #1400:
URL: https://github.com/apache/singa/pull/1400
## Summary
Fix the license-check workflow and Apache RAT configuration.
Changes included:
- Add ASF license headers to TOML files that were missing them:
-
`examples/model_selection/Trails/internal/pg_extension/template/Cargo.pg11.toml`
-
`examples/model_selection/Trails/internal/pg_extension/template/Cargo.pg14.toml`
-
`examples/model_selection/Trails/internal/pg_extension/.cargo/config.toml`
- Remove the RAT exclusion for `Cargo.pg11.toml` now that it has a proper
ASF header.
- Upgrade Apache RAT Maven plugin from `0.13` to `0.18`.
- RAT `0.13` did not recognize the existing
`https://www.apache.org/licenses/LICENSE-2.0` URL in `doap/doap_SINGA.rdf`.
- RAT `0.18` recognizes the HTTPS Apache license URL and resolves the
false-positive failure.
- Rename the Maven profile from `check-licence` to `check-license`.
- Rename the GitHub Actions workflow file from `rat.yaml` to
`license-check.yaml` for clearer naming.
## Why
The `License-Check` GitHub Actions workflow was failing because Apache RAT
reported files with unapproved licenses.
Two TOML files were missing ASF headers, and one similar TOML file was
excluded from RAT instead of being properly licensed. This PR makes the TOML
files consistent
by adding ASF headers and removing the unnecessary exclusion.
The remaining RAT failure was caused by the old RAT `0.13` plugin not
recognizing the HTTPS Apache License URL already present in
`doap/doap_SINGA.rdf`. Upgrading
RAT fixes that issue without changing the DOAP file.
## Validation
Ran the same license-check script used by GitHub Actions:
```bash
PATH=/opt/apache-maven-3.9.16/bin:$PATH bash -ex tool/rat.sh
Result:
[INFO] No issues found.
[INFO] BUILD SUCCESS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
