moazreyad commented on PR #1406:
URL: https://github.com/apache/singa/pull/1406#issuecomment-5885817044
> are all these comments and not affecting the code implementations?
The PR mainly corrects spelling and grammar in comments, documentation, CLI
help, logs, warnings, and error messages. These edits do not change model
calculations.
There are a few code/API-visible changes:
- The C++ declaration `Boradcast` is corrected to `Broadcast`.
- The SWIG-visible `EnableLazyAlloc` parameter changes from `enbale` to
`enable`, which changes the keyword name exposed to Python callers.
- The returned string `"unkown type"` is corrected to `"unknown type"`.
- The phase-one runner’s import was corrected. The PR imported
`controller.py`, while the file was still named `controler.py`; I renamed the
file to `controller.py` in
the latest commit so the import resolves.
The remaining executable-file changes correct user-visible text, such as
log messages, warnings, assertions, and CLI descriptions. So the PR is mostly
text corrections, but it is not limited to comments. No model or training logic
was changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
