+1 having a code style is critical for open source projects with many contributors.
Once a style is agreed upon, I think it should be added in http://singa.incubator.apache.org/develop/contribute-code.html . Committers reviewing the code should then check if it follows the style. If you can setup build tools to do style checks that would be even better. On Wed, Jun 17, 2015 at 1:35 AM, Wang Wei <[email protected]> wrote: > Hi guys, > > Please do a code review when you are getting familiar with the current code. > It is important to make the code clean and easy to read for our first > release. > > We tried to follow the Google's C++ code style initially. But didn't do it > exactly. > If no other suggestions for the coding style, please still follow the > Google's style when doing the code review. > If you have any suggestions, please let us know. > > Thanks. > > regards, > Wei
