[
https://issues.apache.org/jira/browse/SINGA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wang Ji updated SINGA-84:
-------------------------
Description:
Rearrange the folders containing header files and split some of the header
files into separate folders to reduce coupling.
1. Create a new folder named "singa" as the parent directory of original
headers.
Before:
"include/comm/..."
"include/gtest/..."
"include/driver.h"
"include/server.h"
...
After:
"include/singa/comm/..."
"include/singa/gtest/..."
"include/singa/driver.h"
"include/singa/server.h"
...
2. Split header files from "include/neuralnet" into separate directory.
* Split "include/nueralnet/loss_layer.h" into
"include/singa/nueralnet/loss_layer/softmax.h"
"include/singa/nueralnet/loss_layer/euclidean.h"
* Split "include/nueralnet/neuron_layer.h" into
"include/singa/nueralnet/neuron_layer/convolution.h"
"include/singa/nueralnet/neuron_layer/dropout.h"
"include/singa/nueralnet/neuron_layer/lrn.h"
"include/singa/nueralnet/neuron_layer/pooling.h"
"include/singa/nueralnet/neuron_layer/relu.h"
"include/singa/nueralnet/neuron_layer/inner_product.h"
"include/singa/nueralnet/neuron_layer/tanh.h"
"include/singa/nueralnet/neuron_layer/sigmoid.h"
"include/singa/nueralnet/neuron_layer/rbm.h"
containing RBMLayer, RBMVisLayer, RBMHidLayer
* Split "include/nueralnet/input_layer.h" into
"include/singa/nueralnet/input_layer/data.h"
containing DataLayer, ShardDataLayer, LMDBDataLayer
"include/singa/nueralnet/input_layer/parser.h"
containing ParserLayer, LabelLayer, MnistLayer, RGBImageLayer
"include/singa/nueralnet/input_layer/prefetch.h"
containing PrefetchLayer
* Split "include/nueralnet/output_layer.h" into
"include/singa/nueralnet/output_layer/output.h"
* Split "include/nueralnet/connection_layer.h" into
"include/singa/nueralnet/connection_layer/bridge.h"
"include/singa/nueralnet/connection_layer/concate.h"
"include/singa/nueralnet/connection_layer/slice.h"
"include/singa/nueralnet/connection_layer/split.h"
3. Edit the inclusion of header files in corresponding source codes.
was:
Rearrange the folders containing header files and split some of the header
files into separate folders to reduce coupling.
1. Create a new folder named "singa" as the parent directory of original
headers.
Before:
"include/comm/..."
"include/gtest/..."
"include/driver.h"
"include/server.h"
...
After:
"include/singa/comm/..."
"include/singa/gtest/..."
"include/singa/driver.h"
"include/singa/server.h"
...
2. Split header files from "include/neuralnet" into separate directory.
* Split "include/nueralnet/loss_layer.h" into
"include/singa/nueralnet/loss/Softmax_loss_layer.h"
"include/singa/nueralnet/loss/Euclidean_loss_layer.h"
* Split "include/nueralnet/neuron_layer.h" into
"include/singa/nueralnet/neuron/convolution_layer.h"
"include/singa/nueralnet/neuron/dropout_layer.h"
"include/singa/nueralnet/neuron/LRN_Layer.h"
"include/singa/nueralnet/neuron/pooling_Layer.h"
"include/singa/nueralnet/neuron/ReLU_Layer.h"
"include/singa/nueralnet/neuron/inner_product_Layer.h"
"include/singa/nueralnet/neuron/Tanh_Layer.h"
"include/singa/nueralnet/neuron/Sigmoid_Layer.h"
"include/singa/nueralnet/neuron/RBM_Layer.h"
"include/singa/nueralnet/neuron/RBM_visible_Layer.h"
"include/singa/nueralnet/neuron/RBM_hidden_Layer.h"
* Split "include/nueralnet/input_layer.h" into
"include/singa/nueralnet/input/data_layer.h"
containing DataLayer, ShardDataLayer, LMDBDataLayer
"include/singa/nueralnet/input/parser_layer.h"
containing ParserLayer, LabelLayer, MnistLayer, RGBImageLayer
"include/singa/nueralnet/input/prefetch_layer.h"
containing PrefetchLayer
* Split "include/nueralnet/output_layer.h" into
"include/singa/nueralnet/output/output_layer.h"
* Split "include/nueralnet/connection_layer.h" into
"include/singa/nueralnet/connection/bridge_layer.h"
"include/singa/nueralnet/connection/concate_layer.h"
"include/singa/nueralnet/connection/slice_layer.h"
"include/singa/nueralnet/connection/split_layer.h"
3. Edit the inclusion of header files in corresponding source codes.
> Header Files Rearrange
> ----------------------
>
> Key: SINGA-84
> URL: https://issues.apache.org/jira/browse/SINGA-84
> Project: Singa
> Issue Type: Improvement
> Reporter: Wang Ji
> Labels: patch
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Rearrange the folders containing header files and split some of the header
> files into separate folders to reduce coupling.
> 1. Create a new folder named "singa" as the parent directory of original
> headers.
> Before:
> "include/comm/..."
> "include/gtest/..."
> "include/driver.h"
> "include/server.h"
> ...
> After:
> "include/singa/comm/..."
> "include/singa/gtest/..."
> "include/singa/driver.h"
> "include/singa/server.h"
> ...
> 2. Split header files from "include/neuralnet" into separate directory.
> * Split "include/nueralnet/loss_layer.h" into
> "include/singa/nueralnet/loss_layer/softmax.h"
> "include/singa/nueralnet/loss_layer/euclidean.h"
> * Split "include/nueralnet/neuron_layer.h" into
> "include/singa/nueralnet/neuron_layer/convolution.h"
> "include/singa/nueralnet/neuron_layer/dropout.h"
> "include/singa/nueralnet/neuron_layer/lrn.h"
> "include/singa/nueralnet/neuron_layer/pooling.h"
> "include/singa/nueralnet/neuron_layer/relu.h"
> "include/singa/nueralnet/neuron_layer/inner_product.h"
> "include/singa/nueralnet/neuron_layer/tanh.h"
> "include/singa/nueralnet/neuron_layer/sigmoid.h"
> "include/singa/nueralnet/neuron_layer/rbm.h"
> containing RBMLayer, RBMVisLayer, RBMHidLayer
> * Split "include/nueralnet/input_layer.h" into
> "include/singa/nueralnet/input_layer/data.h"
> containing DataLayer, ShardDataLayer, LMDBDataLayer
> "include/singa/nueralnet/input_layer/parser.h"
> containing ParserLayer, LabelLayer, MnistLayer, RGBImageLayer
> "include/singa/nueralnet/input_layer/prefetch.h"
> containing PrefetchLayer
> * Split "include/nueralnet/output_layer.h" into
> "include/singa/nueralnet/output_layer/output.h"
> * Split "include/nueralnet/connection_layer.h" into
> "include/singa/nueralnet/connection_layer/bridge.h"
> "include/singa/nueralnet/connection_layer/concate.h"
> "include/singa/nueralnet/connection_layer/slice.h"
> "include/singa/nueralnet/connection_layer/split.h"
> 3. Edit the inclusion of header files in corresponding source codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
