[
https://issues.apache.org/jira/browse/SINGA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964934#comment-14964934
]
ASF subversion and git services commented on SINGA-94:
------------------------------------------------------
Commit 4abee35a1aa2b9425c4a823a4c37ded641c00115 in incubator-singa's branch
refs/heads/master from [~yeefan]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=4abee35 ]
SINGA-94 Move call to google::InitGoogleLogging() from Driver::Init() to main().
It appears that google::InitGoogleLogging() was never intended to be called
inside a library.
The reason is because calling google::InitGoogleLogging() twice results in
program termination with the error log "You called InitGoogleLogging() twice!".
Calling google::InitGoogleLogging() inside Driver::Init() prevents users of the
Singa library from making this call in their own main() function, as
recommended by glog documentation.
> google::InitGoogleLogging() should be called in main() rather than inside
> Driver::Init()
> ----------------------------------------------------------------------------------------
>
> Key: SINGA-94
> URL: https://issues.apache.org/jira/browse/SINGA-94
> Project: Singa
> Issue Type: Bug
> Reporter: Yee Fan Tan
>
> google::InitGoogleLogging() should be called in main() rather than inside
> Driver::Init().
> Calling google::InitGoogleLogging() twice results in an error log "You called
> InitGoogleLogging() twice!" and the program terminates from a CHECK
> condition. As such, it appears that google::InitGoogleLogging() is not
> intended to be called inside a library, as it prevents the user of the
> library from calling google::InitGoogleLogging() from his own main() function.
> This glog issue appears to confirm what I say:
> https://code.google.com/p/google-glog/issues/detail?id=113
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
