moazreyad commented on issue #416: singa-onnx
URL: https://github.com/apache/incubator-singa/pull/416#issuecomment-472489883
 
 
   It is very hard to follow this pull request. There are more than 130 
comment. I think the singa-onnx task is too large to be implemented in one pull 
request. Also the files in this pull request were changed several times and it 
is not easy to follow the changes.
   
   Can we split the task into smaller sub tasks, so it can be easier to follow?
   
   May be also we can merge some of the completed work in this pull request. We 
may merge with the master branch if the changes are good enough, or in another 
temporary branch for the onnx task. Merging will allow others to create other 
pull requests to add, fix or discuss changes instead of putting everything in 
one pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to