joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx URL: https://github.com/apache/incubator-singa/pull/504#discussion_r313209763
########## File path: test/python/test_onnx.py ########## @@ -0,0 +1,202 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# ============================================================================= + +import unittest +from builtins import str + +from singa import tensor +from singa import singa_wrap as singa +from singa import autograd +from singa import sonnx + +import onnx +from onnx import (defs, checker, helper, numpy_helper, mapping, + ModelProto, GraphProto, NodeProto, AttributeProto, TensorProto, OperatorSetIdProto) +from onnx.helper import make_tensor, make_tensor_value_info, make_node, make_graph + +from cuda_helper import gpu_dev, cpu_dev + +import numpy as np + +autograd.training = True + + +class TestPythonOnnxFrontend(unittest.TestCase): + Review comment: These tese cases are only backend part, that is, they make two tensors, one as input, one as output, then they convert the op to other frameworks, run it and then transfer back the output, they check whether the framework's output is same with the pre-defined onnx's output. They haven't tested the frontend part. Our test cases are converting the singa op to onnx, and convert back, to check the output of singa ops after and before converted whether are same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
