dcslin commented on a change in pull request #533: fixed operation add 
assertion for convolution
URL: https://github.com/apache/incubator-singa/pull/533#discussion_r324502113
 
 

 ##########
 File path: src/core/tensor/tensor_math_cpp.h
 ##########
 @@ -868,6 +868,25 @@ void RowMax<float, lang::Cpp>(const Tensor& in, Tensor 
*out, Context *ctx) {
   }
 }
 
+template <>
+void SoftMax<float, lang::Cpp>(const Tensor& in, Tensor* out, Context *ctx) {
 
 Review comment:
   Hi @nudles , it is not implemented in cpp yet. So we need to move this from 
`tensor.cc` into `tensor_math_cpp.h`. If not, when calling softmax with cpp, it 
will through `not impl` fatal error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to