+1 looking good, Martin. Cheers, Chris
On 2/24/13 2:04 PM, "Martin Desruisseaux" <[email protected]> wrote: >Hello all > >So there is the proposal. The skeleton NamespacePrefixMapper class is >below. To be legally as safe as possible, the class is totally empty. It >does not even have any method signature, since we actually don't need >them for method overriding to work at the binary level (because of Java >"late binding" behaviour). > >https://svn.apache.org/repos/asf/sis/branches/JDK7/sis-utility/src/main/ja >va/com/sun/xml/internal/bind/marshaller/NamespacePrefixMapper.java > >The Apache SIS implementation of that class is >org.apache.sis.xml.OGCNamespacePrefixMapper (a package-private class). >Since we don't know at compile time if we are properly overriding the >methods from the base class, this is verified in the JUnit test using >Java reflection. > >The compilation result of the above com.sun class is deleted by a >maven-antrun-plugin task after the tests have been compiled and before >the tests are run. This should guarantee us that the >NamespacePrefixMapper class used by the tests is the JDK one. > > Martin >
