Le 05/01/15 10:27, Marc LE BIHAN a écrit : > Ok. With all this information, I think we cannot release yet the shapefile > part of the Apache SIS API. Many thanks for this feedback Marc
So the question to the rest of the PMC, do we omit the sis-shapefile from Apache SIS 0.5 release? The advantage would be to remove any pressure on Marc, so he have a full release cycle (maybe 6 months) to review the sis-shapefile module. > For DataStoreException, it's ok if subclasses can be created. > but at the end, DataStoreException will have subclasses to represent > various problems coming from SQL, JPA, other data source causes. > In my mind, as long as the exception thrown by methods can summarize to > DataStoreException when the caller doesn't want to know more, it's ok. He > catches a more specific exception if he really wants too. But at the time > he wants, he can : he only has to change the exception name in his catch > clause. Fine. The door is all open for adding whatever DataStoreException subclasses we need. Maybe the main difficulty will be to identity a set of exceptions that are not too specific to some storage format. > For stream() : > I will study the implementation stream() in JDK 8 Thanks. After a second look, there is much more abstract methods than I though. But an easier way to get started may be to implement a SplitIterator instead: http://docs.oracle.com/javase/8/docs/api/java/util/Spliterator.html Then if we need a stream, we could use: http://docs.oracle.com/javase/8/docs/api/java/util/stream/StreamSupport.html#stream-java.util.function.Supplier-int-boolean- The reason why I suggest to look at those interfaces is that they are designed for parallelization. Even if we do not do parallelization in Shapefile now, other formats may do or future Shapefile implementations may do. Martin
