Hello Martin
> In the commits that I see on the Android branch, in PooledUnmarshaller
> at line 186, an InputStream is opened but I'm not sure where it is closed?
Noted and fixed.
> On a minor note, I see that in various places the "java.io.something"
> imports have been replaced by a single star import ("import java.io.*").
> I would suggest to avoid those replacements, in order to reduce the risk
> of conflicts with future merges.
Thanks I didn't notice that. Actually that should be replaced by the IDE, I will
take care to not happen that again.
> By scanning the list of commits I saw adjustments in I/O operations,
> which is fine. Did you had a chance to make any more progress? In
> particular did you had a chance to test on Android platform?
Currently I am working on porting JDBC to SQLite connectivity in
sis-metadata and sis-referencing modules. I will try tests as soon as
this gets done.
I assume that SQLiteOpenHelper should go into the sis-metadata module
because Initializer class manages the database instance. Android
SQLiteOpenHelper class provides onCreate method which runs when the
database is created for the first time. That's where table creation and data
feeding scripts typically goes. In our case, I don't think we can use that
method because the installation scripts are in sis-referencing module. So
I'll avoid that method and let sis-referencing module create the tables, as
how it is done in trunk.
--
Sisinda
