Hello Martin and all, Thanks for response, I have merge and I make "mvn install " and has error: [ERROR] Tests run: 397, Failures: 2, Errors: 0, Skipped: 5, Time elapsed: 11.906 s <<< FAILURE! - in org.apache.sis.test.suite.MetadataTestSuite [ERROR] testGetIdentifier(org.apache.sis.metadata.iso.citation.CitationsTest) Time elapsed: 0.001 s <<< FAILURE! java.lang.AssertionError: expected:<ESRI:ArcGIS> but was:<null> at org.apache.sis.metadata.iso.citation.CitationsTest.testGetIdentifier(CitationsTest.java:125)
[ERROR] testGetTitles(org.apache.sis.metadata.iso.citation.CitationsTest) Time elapsed: 0 s <<< FAILURE! java.lang.AssertionError: GEOTIFF at org.apache.sis.metadata.iso.citation.CitationsTest.testGetTitles(CitationsTest.java:209) [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] CitationsTest.testGetIdentifier:125 expected:<ESRI:ArcGIS> but was:<null> [ERROR] CitationsTest.testGetTitles:209 GEOTIFF [INFO] [ERROR] Tests run: 397, Failures: 2, Errors: 0, Skipped: 5 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Apache SIS ......................................... SUCCESS [ 3.402 s] [INFO] Apache SIS build helper ............................ SUCCESS [ 5.512 s] [INFO] Apache SIS core modules ............................ SUCCESS [ 0.549 s] [INFO] Apache SIS utilities ............................... SUCCESS [ 11.927 s] [INFO] Apache SIS metadata ................................ FAILURE [ 13.173 s] [INFO] Apache SIS referencing ............................. SKIPPED [INFO] Apache SIS referencing by geographic identifiers ... SKIPPED [INFO] Apache SIS features ................................ SKIPPED [INFO] Apache SIS rasters ................................. SKIPPED [INFO] Apache SIS storage ................................. SKIPPED [INFO] Apache SIS common storage .......................... SKIPPED [INFO] Apache SIS portrayal ............................... SKIPPED [INFO] Apache SIS Shapefile storage ....................... SKIPPED [INFO] Apache SIS XML storage ............................. SKIPPED [INFO] Apache SIS SQL storage ............................. SKIPPED [INFO] Apache SIS netCDF storage .......................... SKIPPED [INFO] Apache SIS GeoTIFF storage ......................... SKIPPED [INFO] Apache SIS Earth Observation storage ............... SKIPPED [INFO] Apache SIS bindings for Proj4 ...................... SKIPPED [INFO] Apache SIS applications ............................ SKIPPED [INFO] Apache SIS console ................................. SKIPPED [INFO] Apache SIS application for JavaFX .................. SKIPPED [INFO] Apache SIS web services layer ...................... SKIPPED [INFO] Apache SIS profiles ................................ SKIPPED [INFO] Apache SIS French profiles ......................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 35.520 s [INFO] Finished at: 2018-07-31T09:49:02+07:00 [INFO] Final Memory: 45M/531M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on project sis-metadata: There are test failures. [ERROR] [ERROR] Please refer to /home/haonguyen/GSOC2018/sis/core/sis-metadata/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :sis-metadata But when I use "mvn clean install -DskipTests -Dfindbugs.skip=true -Dpmd.skip=true -Dmaven.javadoc.skip=true" it build success . Does it have any effect ? >>I suspect that most classes in CSW and OWS packages are for internal use by the "sis-webapp" module. Is that right? If yes, then we may not need getter and setter methods, since no one else than "sis-webapp" would use those classes. Instead, the JAXB annotations could be on the fields directly. This would make smaller classes. I don't understand , Does that mean I don't need use get set for these classes ? Thanks Hao On Mon, Jul 30, 2018 at 4:17 AM Martin Desruisseaux < [email protected]> wrote: > Hello Hao > > I have pushed on [1] a clone of you work + merge with latest SIS > development and removal of trailing spaces (for allowing Checkstyle checks > to pass). You can merge with your work if convenient. Note however that > recent SIS development introduces one change in metadata database: when > creating table in the databases, the ISO prefixes (for example "CI_" in > "CI_Citation") is now dropped. In other words, the table created by SIS > in the database is no longer named "CI_Citation", but is named "Citation" > instead. This change is motivated in part because, in my understanding, ISO > is dropping the prefixes in new standards. > > On the Google Summer of Code work, I suggest to do the following tasks: > > - Make sure that "mvn install" works from the command line, with tests > enabled. Please let us know if you encounter any issue. > - In org.apache.sis.services.ows.package-info, add a Javadoc telling > from which standard those classes come from, how they were generated (JAXB > compiler?) and, if you modified the result, what were the modifications. > - In the org.apache.sis.services.ows package, classes Address, > Telephone and OnlineResource seem similar to ISO 19115 classes of the > same name. Can you add a note in their javadoc describing the relationship > with ISO 19115? > - RequestMethod has javadoc interleaved with JAXB annotations. The > order should be class Javadoc, then annotations, then class declaration. > Same for OwsServiceProvider, OwsServiceIdentification and others. > - You can remove the @SuppressWarnings("CloneableClassWithoutClone") > annotations; they do not apply to the classes in this package. > - org.apache.sis.services.csw.ogcservice.GetCapabilities, Capabilities, > InsertResult and others have the license header at the wrong location. > - org.apache.sis.services.csw.impl.OGCServiceImpl and > org.apache.sis.services.csw.discovery.GetDomainResponse are completely > empty. Are these classes used? > > Many classes, fields or methods have empty javadoc tags. For example: > > /** > * > * @param transaction > * @return > */ > > Ideally the Javadoc should be completed. But if not (for example because > they are redundant with other information), I think it is better to > completely remove those tags instead than keeping empty tags, in order to > avoid giving a false impression of completeness. But if you plan to > complete javadoc, before doing so see next item. > > I suspect that most classes in CSW and OWS packages are for internal use > by the "sis-webapp" module. Is that right? If yes, then we may not need > getter and setter methods, since no one else than "sis-webapp" would use > those classes. Instead, the JAXB annotations could be on the fields > directly. This would make smaller classes. > > Thanks! > > Martin > > [1] https://github.com/desruisseaux/sis/tree/CSW > >
