wu-sheng commented on a change in pull request #738: Concurrency conflicts in
Spring plugin #735
URL:
https://github.com/apache/incubator-skywalking/pull/738#discussion_r160863684
##########
File path:
apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/EnhanceRequireObjectCache.java
##########
@@ -52,10 +53,11 @@ public PathMappingCache getPathMappingCache() {
}
public void setHttpResponse(HttpServletResponse httpResponse) {
- this.httpResponse = httpResponse;
+ this.httpResponse.set(httpResponse);
}
public HttpServletResponse getHttpResponse() {
Review comment:
This method is never used. Recommend remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
