wu-sheng commented on a change in pull request #790: [Agent] Fix grpc don't
works in 1.8 version
URL:
https://github.com/apache/incubator-skywalking/pull/790#discussion_r166195308
##########
File path:
apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/AbstractServerImplBuilderInterceptor.java
##########
@@ -16,37 +16,36 @@
*
*/
-
package org.apache.skywalking.apm.plugin.grpc.v1;
-import io.grpc.internal.ManagedChannelImpl;
+import io.grpc.ServerInterceptors;
+import io.grpc.ServerServiceDefinition;
import java.lang.reflect.Method;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
-import org.apache.skywalking.apm.plugin.grpc.v1.vo.GRPCDynamicFields;
/**
- * {@link ManagedChannelInterceptor} record the IP address of the GRPC server
into {@link GRPCDynamicFields} for build
- * span.
+ * {@link AbstractServerImplBuilderInterceptor} add the {@link
CallServerInterceptor} interceptor for each the
Review comment:
For `every` ServerSerivce?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
