hanahmily closed pull request #819: Change the data type of sla and apdex 
attributes from Float to Int.
URL: https://github.com/apache/incubator-skywalking/pull/819
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/application-layer.graphqls
 
b/apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/application-layer.graphqls
index 1cf9643f3..e527d6e4e 100644
--- 
a/apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/application-layer.graphqls
+++ 
b/apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/application-layer.graphqls
@@ -4,17 +4,17 @@ type ApplicationNode implements Node {
     name: String!
     type: String
     # Success rate of all incoming requests.
-    # Max value is 100.
-    # 2 Digits after floating point.
-    sla: Float!
+    # Max value is 10000.
+    # 2 Digits after floating point in UI, need to division by 100. 10000 -> 
100.00
+    sla: Int!
     # The number of incoming calls
     callsPerSec: Long!
     # Unit: millisecond
     responseTimePerSec: Long!
     # ref: http://www.apdex.org/
-    # Max value is 1
-    # 2 Digits after floating point.
-    apdex: Float!
+    # Max value is 100
+    # 2 Digits after floating point in UI, need to division by 100. 100 -> 1.00
+    apdex: Int!
     # Whether the application alerts?
     # Default value is false.
     isAlarm: Boolean!


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to