ascrutae commented on a change in pull request #832: Add [Agent] Jedis LETTUCE client plugin URL: https://github.com/apache/incubator-skywalking/pull/832#discussion_r170845594
########## File path: apm-sniffer/apm-sdk-plugin/lettuce-plugin/lettuce-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/lettuce/v4/StatefulRedisConnectionImplInterceptor.java ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.plugin.lettuce.v4; + +import com.lambdaworks.redis.protocol.RedisCommand; +import java.lang.reflect.Method; +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.context.tag.Tags; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult; +import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; + +public class StatefulRedisConnectionImplInterceptor implements InstanceMethodsAroundInterceptor, InstanceConstructorInterceptor { + + @Override + public void onConstruct(EnhancedInstance objInst, Object[] allArguments) { + EnhancedInstance commandHandler = (EnhancedInstance)allArguments[0]; + String peer = (String)commandHandler.getSkyWalkingDynamicField(); + objInst.setSkyWalkingDynamicField(peer); + } + + @Override public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, + Class<?>[] argumentsTypes, MethodInterceptResult result) throws Throwable { + RedisCommand command = (RedisCommand)allArguments[0]; + String comandType = String.valueOf(command.getType()); + if (checkIgnoreCommandType(comandType)) { + String peer = String.valueOf(objInst.getSkyWalkingDynamicField()); + AbstractSpan span = ContextManager.createExitSpan("REDIS-Lettuce/" + comandType, peer); + span.setComponent(ComponentsDefine.REDIS); + Tags.DB_TYPE.set(span, "Redis"); + SpanLayer.asCache(span); + Tags.DB_STATEMENT.set(span, command.getArgs().toString()); + } + } + + @Override + public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, + Object ret) throws Throwable { + RedisCommand command = (RedisCommand)allArguments[0]; + if (null != command.getOutput().getError()) { + AbstractSpan span = ContextManager.activeSpan(); + span.errorOccurred(); + } + ContextManager.stopSpan(); Review comment: It maybe cause exception if the command type is ignore command type, because of I saw that `StatefulRedisClusterConnectionImplInterceptor` doesn't create span if the command type is ignore command type ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
