wu-sheng commented on a change in pull request #871: Add elasticSearch-http storage module. URL: https://github.com/apache/incubator-skywalking/pull/871#discussion_r178456173
########## File path: apm-collector/apm-collector-component/client-component/pom.xml ########## @@ -17,94 +17,99 @@ ~ --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <parent> - <artifactId>apm-collector-component</artifactId> - <groupId>org.apache.skywalking</groupId> - <version>5.0.0-alpha-SNAPSHOT</version> - </parent> - <modelVersion>4.0.0</modelVersion> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>apm-collector-component</artifactId> + <groupId>org.apache.skywalking</groupId> + <version>5.0.0-alpha-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> - <artifactId>client-component</artifactId> - <packaging>jar</packaging> - <dependencies> - <dependency> - <groupId>com.h2database</groupId> - <artifactId>h2</artifactId> - <version>1.4.196</version> - </dependency> - <dependency> - <groupId>redis.clients</groupId> - <artifactId>jedis</artifactId> - <version>2.9.0</version> - </dependency> - <dependency> - <groupId>org.elasticsearch.client</groupId> - <artifactId>transport</artifactId> - <version>5.5.0</version> - <exclusions> - <exclusion> - <artifactId>snakeyaml</artifactId> - <groupId>org.yaml</groupId> - </exclusion> - <exclusion> - <artifactId>netty-common</artifactId> - <groupId>io.netty</groupId> - </exclusion> - <exclusion> - <artifactId>netty-transport</artifactId> - <groupId>io.netty</groupId> - </exclusion> - <exclusion> - <artifactId>netty-codec</artifactId> - <groupId>io.netty</groupId> - </exclusion> - <exclusion> - <artifactId>netty-codec-http</artifactId> - <groupId>io.netty</groupId> - </exclusion> - <exclusion> - <artifactId>netty-buffer</artifactId> - <groupId>io.netty</groupId> - </exclusion> - <exclusion> - <artifactId>netty-handler</artifactId> - <groupId>io.netty</groupId> - </exclusion> - <exclusion> - <artifactId>netty-resolver</artifactId> - <groupId>io.netty</groupId> - </exclusion> - </exclusions> - </dependency> - <dependency> - <groupId>org.apache.zookeeper</groupId> - <artifactId>zookeeper</artifactId> - <version>3.4.10</version> - <exclusions> - <exclusion> - <artifactId>slf4j-api</artifactId> - <groupId>org.slf4j</groupId> - </exclusion> - <exclusion> - <artifactId>slf4j-log4j12</artifactId> - <groupId>org.slf4j</groupId> - </exclusion> - </exclusions> - </dependency> - <dependency> - <groupId>org.apache.skywalking</groupId> - <artifactId>apm-network</artifactId> - <version>${project.version}</version> - <exclusions> - <exclusion> - <artifactId>guava</artifactId> - <groupId>com.google.guava</groupId> - </exclusion> - </exclusions> - </dependency> - </dependencies> + <artifactId>client-component</artifactId> + <packaging>jar</packaging> + + <dependencies> + <dependency> + <groupId>com.h2database</groupId> + <artifactId>h2</artifactId> + <version>1.4.196</version> + </dependency> + <dependency> + <groupId>redis.clients</groupId> + <artifactId>jedis</artifactId> + <version>2.9.0</version> + </dependency> + <dependency> + <groupId>org.elasticsearch.client</groupId> + <artifactId>transport</artifactId> + <version>5.5.0</version> + <exclusions> + <exclusion> + <artifactId>snakeyaml</artifactId> + <groupId>org.yaml</groupId> + </exclusion> + <exclusion> + <artifactId>netty-common</artifactId> + <groupId>io.netty</groupId> + </exclusion> + <exclusion> + <artifactId>netty-transport</artifactId> + <groupId>io.netty</groupId> + </exclusion> + <exclusion> + <artifactId>netty-codec</artifactId> + <groupId>io.netty</groupId> + </exclusion> + <exclusion> + <artifactId>netty-codec-http</artifactId> + <groupId>io.netty</groupId> + </exclusion> + <exclusion> + <artifactId>netty-buffer</artifactId> + <groupId>io.netty</groupId> + </exclusion> + <exclusion> + <artifactId>netty-handler</artifactId> + <groupId>io.netty</groupId> + </exclusion> + <exclusion> + <artifactId>netty-resolver</artifactId> + <groupId>io.netty</groupId> + </exclusion> + </exclusions> + </dependency> + <dependency> + <groupId>org.apache.zookeeper</groupId> + <artifactId>zookeeper</artifactId> + <version>3.4.10</version> + <exclusions> + <exclusion> + <artifactId>slf4j-api</artifactId> + <groupId>org.slf4j</groupId> + </exclusion> + <exclusion> + <artifactId>slf4j-log4j12</artifactId> + <groupId>org.slf4j</groupId> + </exclusion> + </exclusions> + </dependency> + <dependency> + <groupId>org.apache.skywalking</groupId> + <artifactId>apm-network</artifactId> + <version>${project.version}</version> + <exclusions> + <exclusion> + <artifactId>guava</artifactId> + <groupId>com.google.guava</groupId> + </exclusion> + </exclusions> + </dependency> + <dependency> + <groupId>io.searchbox</groupId> + <artifactId>jest</artifactId> + <version>5.3.3</version> + </dependency> + </dependencies> Review comment: Why is this file format so different? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
