Hi, Ian

I just updated this PR  https://github.com/apache/incubator-dubbo/pull/2681 
<https://github.com/apache/incubator-dubbo/pull/2681> following your 
suggestions, could you help to check it again?

Remember there’s another PR https://github.com/apache/incubator-dubbo/pull/2682 
<https://github.com/apache/incubator-dubbo/pull/2682> for master branch.

Best regards,
Jun

> On Oct 24, 2018, at 12:30 PM, jun liu <[email protected]> wrote:
> 
> I have created a patch[1] to fix this problem, briefly changes:
> * Add optional Inject annotation for developers to decide open auto-injection 
> or not.
> * Printing log instead of throwing Exception in SpringExtensionFactory when 
> multi-extension or no extension found.
> 
> 1. https://github.com/apache/incubator-dubbo/pull/2681 
> <https://github.com/apache/incubator-dubbo/pull/2681>
> 
> Best regards,
> Jun
> 
>> On Oct 23, 2018, at 11:01 AM, Sheng Wu <[email protected] 
>> <mailto:[email protected]>> wrote:
>> 
>> Hi 
>> 
>> I am moving a SkyWalking bug report[1] to here. SkyWalking supports Dubbo 
>> for a long time and works well. But recent days, people begin to report bug 
>> of monitoring Dubbo 2.6.2, looks like added some mechanism to make the 
>> conflicts.
>> 
>> Could you go to the issue I post, we could continue the discussion there? 
>> Why add those new codes and what is the solution for supporting dubbo from 
>> SkyWalking.
>> 
>> [1] https://github.com/apache/incubator-skywalking/issues/1769 
>> <https://github.com/apache/incubator-skywalking/issues/1769>
>> 
>> Sheng Wu
>> SkyWalking
> 

Reply via email to