Hi Xin Thanks for clarifying this. I think this is a valid +1. Please make sure the checked list in mail matched your steps. Thanks.
Ignasi, Thoughts? Sheng Wu 吴晟 Apache SkyWalking, ShardingSphere, Zipkin Twitter, wusheng1108 xin zhang <[email protected]> 于2019年5月1日周三 上午8:38写道： > Here is the validate-relase-package.sh[1] > > Regards > > Xin > > [1] https://gist.github.com/ascrutae/4c665f061cac977e83a384fef585aa5b < > https://gist.github.com/ascrutae/4c665f061cac977e83a384fef585aa5b> > > > > On May 1, 2019, at 7:51 AM, xin zhang <[email protected]> wrote: > > > > Hi Ignasi > > > > I had used the `validate-release-package.sh` to validate the release > package. > > And I check this script and the script don’t verify the DISCLAIMER. > > > > Sorry for my fault. I copied the list. > > > > > > Regards > > > > Xin > > > > <validate-release-package.sh> > > > >> On Apr 30, 2019, at 11:06 PM, Sheng Wu <[email protected]> > wrote: > >> > >> Xin, > >> > >> I noticed that too. Could you confirm what you have done? > >> > >> I will ignore your +1 at this moment until we get further update. > >> > >> Sheng Wu 吴晟 > >> > >> Apache SkyWalking, ShardingSphere, Zipkin > >> Twitter, wusheng1108 > >> > >> > >> Ignasi Barrera <[email protected]> 于2019年4月30日周二 下午10:56写道： > >> > >>> Is this a thorough list or just a copy paste? What DISCLAIMER have you > >>> verified? > >>> > >>> On Tue, 30 Apr 2019 at 16:38, xin zhang <[email protected]> wrote: > >>> > >>>> +1 (binding) > >>>> > >>>> Here is the list I checked: > >>>> 1. Features tested > >>>> 2. All package has asc and md5 files > >>>> 3. ASC and MD5 files checked > >>>> 4. LICENSE and NOTICE files checked > >>>> 5. Build sucess from source code package > >>>> 6. Apache RAT checked. > >>>> 7. DISCLAIMER exists > >>>> > >>>> Regards > >>>> > >>>> Xin > >>>> > >>>>> On Apr 30, 2019, at 8:37 PM, Hongtao Gao <[email protected]> > wrote: > >>>>> > >>>>> +1 (binding) > >>>>> > >>>>> I had checked the following items: > >>>>> 1.All test cases is passed > >>>>> 2.asc,*sha512 files are correct > >>>>> 3.Building binary from source code > >>>>> 4.Both source and binary packages contains LICENSE and NOTICE files. > >>>>> 5.No error found after running apache-rat > >>>>> > >>>>> Hongtao Gao > >>>>> > >>>>> Apache SkyWalking && Apache ShardingSphere > >>>>> Twitter, @hanahmily > >>>>> > >>>>>> On Apr 30, 2019, at 5:25 PM, Sheng Wu <[email protected]> wrote: > >>>>>> > >>>>>> Hi All, > >>>>>> This is a call for vote to release Apache SkyWalking version > >>>> 6.1.0.[Round 2] > >>>>>> This will be the first release as TLP and including RocketBot as > >>>> primary UI. > >>>>>> > >>>>>> The round fails because of source compiling issue. > >>>>>> > >>>>>> Release notes: > >>>>>> > >>>>>> * https://github.com/apache/skywalking/blob/v6.1.0/CHANGES.md > >>>>>> > >>>>>> Release Candidate: > >>>>>> > >>>>>> * https://dist.apache.org/repos/dist/dev/skywalking/6.1.0/ > >>>>>> > >>>>>> Please notice the following new checksums, the svn web page may have > >>>> cache. > >>>>>> > >>>>>> * sha512 checksums > >>>>>> - > >>>> > >>> > 9571e3d23d50c6d88e6d4231f5f2c0ca30cc7e8ee41757d1e4def1c824d39aa9ea56a5f45bea0084a4490461de8275ba09cadad836ac992b97070c906e02389f > >>>>>> apache-skywalking-apm-6.1.0-src.tgz > >>>>>> - > >>>> > >>> > 54fe85c984c369fd2731aa10190ee7e82e15e2c7c9528234993f6c3d4db34d19735b5467875e20dc3f8476e8d6d56d4fcd6118b4aff49f7b5a7215ee032918c0 > >>>>>> apache-skywalking-apm-6.1.0.tar.gz > >>>>>> - > >>>> > >>> > b9c28886c637c50c66ea94f6c55441972f82886f8d158ec22ddad72460a275c72ad315eb8cfecd8ea586f6ddc5830d2fc971b46abf6640685f51ca54756bb07c > >>>>>> apache-skywalking-apm-6.1.0.zip > >>>>>> > >>>>>> Maven 2 staging repository: > >>>>>> > >>>>>> * > >>>>>> > >>>> > >>> > https://repository.apache.org/content/repositories/orgapacheskywalking-1030/org/apache/skywalking/apache-skywalking-apm/6.1.0/ > >>>>>> > >>>>>> Release Tag : > >>>>>> > >>>>>> * v6.1.0 > >>>>>> > >>>>>> Release CommitID : > >>>>>> > >>>>>> * https://github.com/apache/skywalking/tree/ > >>>>>> < > >>>> > >>> > https://github.com/apache/skywalking/tree/86f2dde46b58f950e8393031f962421497303bfc > >>>>> > >>>>>> *ce0513307aba846e4568b6fc5e949cd9426ca10a* > >>>>>> * Git submodule > >>>>>> * skywalking-ui: > >>>>>> > >>>> > >>> > https://github.com/apache/skywalking-rocketbot-ui/tree/b12a5499f0383a1285b485070e11289052692ac9 > >>>>>> * apm-protocol/apm-network/src/main/proto: > >>>>>> > >>>> > >>> > https://github.com/apache/skywalking-data-collect-protocol/tree/b000505f5885b3337db9441bfb6feab8cfd9ab76 > >>>>>> * > >>>>>> > >>>> > >>> > oap-server/server-query-plugin/query-graphql-plugin/src/main/resources/query-protocol > >>>>>> > >>>> > >>> > https://github.com/apache/skywalking-query-protocol/tree/02ddbfa8d84865e1a85a25f49933307970d0ab71 > >>>>>> > >>>>>> Keys to verify the Release Candidate : > >>>>>> > >>>>>> * https://dist.apache.org/repos/dist/release/skywalking/KEYS > >>>>>> > >>>>>> Guide to build the release from source : > >>>>>> > >>>>>> * > >>>>>> > >>>> > >>> > https://github.com/apache/skywalking/blob/x.y.z/docs/en/guides/How-to-build.md > >>>>>> > >>>>>> Voting will start now (2019-04-30 date) and will remain open for at > >>>> least > >>>>>> 72 hours, Request all PMC members to give their vote. > >>>>>> [ ] +1 Release this package. > >>>>>> [ ] +0 No opinion. > >>>>>> [ ] -1 Do not release this package because.... > >>>>>> > >>>>>> Sheng Wu 吴晟 > >>>>>> > >>>>>> Apache SkyWalking, ShardingSphere, Zipkin > >>>>>> Twitter, wusheng1108 > >>>>> > >>>> > >>>> > >>> > > > >
