Since this is not a real license issue (thanks for pointing it out), I’d like to change my vote to +1 (no binding) to release 6.2.0
> On Jun 29, 2019, at 11:46, Sheng Wu <[email protected]> wrote: > > Thanks for catching this issue. > > This looks like just a typo for me. Not a real license issue. > > I search GitHub for minimao(https://github.com/search?q=minimao-json > <https://github.com/search?q=minimao-json>), there is no such dependency. > And license pointer and license file are right, targeting to `minimal-json` > > I think we could fix this in next release. Please submit a pull request to > fix this in master. > > > > Sheng Wu > Apache Skywalking, ShardingSphere, Zipkin > > > >> 在 2019年6月29日，上午11:36，kezhenxu94 <[email protected]> 写道： >> >> Hi All, >> I've checked the following and I'm -1 (no binding) to release 6.2.0 because: >> the LICENSE of dependency `minimal-json` is not correct in `LICENSE` file[1], >> neither is it in the dist `LICENSE` file, >> >> >> minimao-json 0.9.5: https://github.com/ralfstx/minimal-json, MIT >> >> >> should be >> >> >> minimal-json 0.9.5: https://github.com/ralfstx/minimal-json, MIT >> >> >> All other items in the vote checklist are ok to me as far as I have checked. >> >> >> [1] >> https://github.com/apache/skywalking/blob/6be9448850e6ad4cf679f757caa04e4a93784b7a/apm-dist/release-docs/LICENSE#L341 >> >> >> [x] Features tests: >> 1. test oap in standalone mode with H2 storage, **checked** >> 2. test oap in cluster mode(Nacos coordinator) with ES storage, **checked** >> 3. SkyWalking UI is rendered as expected, **checked** >> [x] All artifacts in staging repository are published with .asc, sha512 files >> [x] Source code and distribution package >> (apache-skywalking-6.2.0-src.tar.gz, apache-skywalking-bin-6.2.0.tar.gz, >> apache-skywalking-bin-6.2.0.zip) are in >> https://dist.apache.org/repos/dist/dev/skywalking/6.2.0 with .asc, .sha512 >> **checked** >> [ ] LICENSE and NOTICE are in Source code and distribution package. >> **UNCHECKED** >> [x] Check shasum -c apache-skywalking-apm-6.2.0-src.tgz.sha512 **CHECKED** >> [x] Build distribution from source code package >> (apache-skywalking-6.2.0-src.tar.gz) **CHECKED** >> [x] Apache RAT check. Run ./mvnw apache-rat:check. **CHECKED** >> >> >> Thanks >> >> At 2019-06-29 09:46:54, "Sheng Wu" <[email protected]> wrote: >>> Hi All, >>> This is a call for vote to release Apache SkyWalking version 6.2.0 >>> >>> Release notes: >>> >>> * https://github.com/apache/skywalking/blob/v6.2.0/CHANGES.md#620 >>> <https://github.com/apache/skywalking/blob/v6.2.0/CHANGES.md#620> >>> >>> Release Candidate: >>> >>> * https://dist.apache.org/repos/dist/dev/skywalking/6.2.0/ >>> <https://dist.apache.org/repos/dist/dev/skywalking/6.2.0/> >>> * sha512 checksums >>> - >>> ae39454f4da31b3fc5750f7fed63558d7e4ac3726dcd1fdb9ddb3e67cfe0389dfa1eea59fbed63d78e106a738114ea62980dc7dda333585abd2c93106dfa9920 >>> apache-skywalking-apm-6.2.0-src.tgz >>> - >>> 753cd9cfeca258cb31355be9c6f8d7e234a488b29b20d1f0e8b3c89c404bcf4fce49fa825c5cb674a42d56e8dc3947b9592b3c8d96c82df84b3926eb341481a6 >>> apache-skywalking-apm-6.2.0.tar.gz >>> - >>> 377655aaf186193dc3356dedab9ef0243665b1cabeeced028c39fc21a5b86aef9b0806ed0f7334447b7ca45f8c0443986b5b2fc7d39fa3510d691d8f96a0c455 >>> apache-skywalking-apm-6.2.0.zip >>> >>> >>> Maven 2 staging repository: >>> >>> * >>> https://repository.apache.org/content/repositories/orgapacheskywalking-1031/org/apache/skywalking >>> >>> <https://repository.apache.org/content/repositories/orgapacheskywalking-1031/org/apache/skywalking> >>> >>> Release Tag : >>> >>> * v6.2.0 >>> >>> Release CommitID : >>> >>> * >>> https://github.com/apache/skywalking/tree/6be9448850e6ad4cf679f757caa04e4a93784b7a >>> * Git submodule >>> * skywalking-ui: >>> https://github.com/apache/skywalking-rocketbot-ui/tree/fa014a13d6eb0f98874d80a54bf4e2ce51176bf6 >>> >>> <https://github.com/apache/skywalking-rocketbot-ui/tree/fa014a13d6eb0f98874d80a54bf4e2ce51176bf6> >>> * apm-protocol/apm-network/src/main/proto: >>> https://github.com/apache/skywalking-data-collect-protocol/tree/ef3f6f0c18db9e4d11dbdd7ceacd16df456c3a1b >>> >>> <https://github.com/apache/skywalking-data-collect-protocol/tree/ef3f6f0c18db9e4d11dbdd7ceacd16df456c3a1b> >>> * >>> oap-server/server-query-plugin/query-graphql-plugin/src/main/resources/query-protocol >>> >>> https://github.com/apache/skywalking-query-protocol/tree/6fc96650acc7f539fcdf6d51648525ce93e5fa1a >>> >>> <https://github.com/apache/skywalking-query-protocol/tree/6fc96650acc7f539fcdf6d51648525ce93e5fa1a> >>> >>> Keys to verify the Release Candidate : >>> >>> * https://dist.apache.org/repos/dist/release/skywalking/KEYS >>> >>> Guide to build the release from source : >>> >>> * >>> https://github.com/apache/skywalking/blob/v6.2.0/docs/en/guides/How-to-build.md >>> >>> Voting will start now (June 29th UTC +8) and will remain open for at least >>> 72 hours, Request all PMC members to give their vote. >>> [ ] +1 Release this package. >>> [ ] +0 No opinion. >>> [ ] -1 Do not release this package because.... >>> >>> Sheng Wu >>> Apache Skywalking, ShardingSphere, Zipkin >>> >>> >>> >
