Hi,
I modified the design and implementation for this improvement based community’s suggestion, and the Pr[1] has been updated, welcome your review. [1] https://github.com/apache/skywalking/pull/3564 Best wishes, Trista Juan Pan [email protected] Juan Pan(Trista), Apache ShardingSphere On 10/6/2019 18:41，Juan Pan<[email protected]> wrote： Got it, not yet. Thanks for your prompt reply. :) Juan Pan [email protected] Juan Pan(Trista), Apache ShardingSphere On 10/6/2019 18:31，kezhenxu94<[email protected]> wrote： BTW, when i run the integrated tests, i got the following exception, can anyone give me some ideas? As for the exception in integration tests, do you have a docker daemon running on your machine? We use docker containers for some of the integration tests. -- GitHub @kezhenxu94 Apache SkyWalking, Apache Dubbo At 2019-10-06 18:27:35, "Juan Pan" <[email protected]> wrote: Hi I raised a pr[1] to do this performance, waiting for your review. BTW, when i run the integrated tests, i got the following exception, can anyone give me some ideas? Regards, Trista [1] https://github.com/apache/skywalking/pull/3564 ``` [ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.30.0:start (prepare-elasticsearch) on project library-client: Execution prepare-elasticsearch of goal io.fabric8:docker-maven-plugin:0.30.0:start failed: No <dockerHost> given, no DOCKER_HOST environment variable, no read/writable '/var/run/docker.sock' or '//./pipe/docker_engine' and no external provider like Docker machine configured - ``` Juan Pan [email protected] Juan Pan(Trista), Apache ShardingSphere On 09/30/2019 18:44，Juan Pan<[email protected]> wrote： Hi everyone, If all properties in the `datasource-settings.properties` are moved into `application.yml`, any property for database could be changed through system env. How to do that? Given skyWalking use `HikariCP` for JDBC connection, my initial idea is to put all the configurations for `HikariCP` to `MySQLStorageConfig` extending ModuleConfig. Is it worth doing this improvement? Or any one has some better ideas? Thanks, Trista Juan Pan [email protected] Juan Pan(Trista), Apache ShardingSphere On 09/28/2019 21:41，Juan Pan<[email protected]> wrote： Thanks for your rely. I will consider about your `better things`. (^_^) Juan Pan [email protected] Juan Pan(Trista), Apache ShardingSphere On 09/27/2019 19:20, 吴晟 Sheng Wu wrote: datasource-settings.properties file is loaded by codes, through file name only. But the better things for application.yml are two 1. It could be overrided by system env, which is much more friendly than config file change. 2. In our container definition, application yaml file could be change through system env, not just values of config items, but including provider names. You could read skywalking-docker about this. This file should be merged into application.yaml, and it is open to change. Please submit pull request if you want. Sheng Wu Apache SkyWalking, ShardingSphere, Zipkin From Wu Sheng 's phone. ------------------ Original ------------------ From: Juan Pan <[email protected]> Date: Fri,Sep 27,2019 7:14 PM To: dev <[email protected]> Subject: Re: Why is `datasource-settings.properties` necessary when storage is `MySQL` Hi everyone, I am exploring SkyWalking, and i find when storage is`MySQL, `datasource-settings.properties` is needed to set properties, while all the properties of H2 storage can be set through `application.yml`. Why is `datasource-settings.properties` necessary for MySQL storage? Do they have different loading mechanism？ Thanks for your help. :) Regards, Trista Juan Pan [email protected] Juan Pan(Trista), Apache ShardingSphere
