>From my understanding, `rewrite` is done for a long time.
We are discussing whether deleting the Deprecated method(6 months ago).
My suggestion is, don't delete them, but we should make sure inside the
main repo(open source), we don't use them. Otherwise, no API could be
deleted eventually.

Sheng Wu 吴晟
Twitter, wusheng1108


johnniang <[email protected]> 于2020年2月5日周三 下午4:50写道:

> Dear Skywalking Developers,
>
> Thank you for wu.sheng invitation for discussing about Deprecated API,
> I've thrown my suggestion below the PR:
> <https://github.com/apache/skywalking/pull/4318>.
>
>
> Here's a copy:
>
>
> We can't avoid using deprecated method, but it's our duty to tell future
> users that method is deprecated.
>
> Just like recent rectifications of invoking rewrited method in
> deprecated method body, but keep|Deprecated|annotation on the deprecated
> method.
>
> e.g.
>
> @Deprecated  // Keep this annotation
> public  T  deprecatedMethod() {
>      return  newMethod();
> }
>
> public  T  rewritedMethod() {
>      // Latest codes here...
> }
>
> In a short, Using|Deprecated|api is my suggestion.
>
>
> BR.
>
> johnniang
>
>

Reply via email to