This's a valuable discussion, but I think we can reach a conclusion in a short time.
My personal preference is not to require more than one viewer for *EVERY* PR. For example, if I tweak a single line of the config file in one PR, I don't want to wait for 2 reviews to help me with it. But the rule of which PR needs more than one reviewer varies. Below is one of them: With https://github.com/marketplace/pull-request-size , we can calculate the size of PR. If the number is more than "M", we can "REQUIRE" two reviews to verify it.Some OSS pick it up and seems to work well. But it's far from perfect(someone might split their work to several small PRs), but a good start. Anyway, invite more people to review PR is something really important to us. But for me, if there is no rule here, I don't have much desire to do it. Shame on me! xD. Sheng Wu <[email protected]> 于2020年2月16日周日 上午10:30写道： > Hi Dev and committer team > > Since today, we have 207 contributors in our main repo. And many PRs landed > every week, which have to be approved by one person. But with the > increasement of the committer and the community, I want to ask your opinion > about > > Do we need to set up the rule for the main repo,* requiring two approvers > for every PR?* > > I am not a preferred answer, and Jian Tan asked about this in a PR several > months ago. > Recently, I and Zhenxu Ke are the most active reviewers, if we could have > more committers are willing to sign up to do the routine review, please let > me know. Routine review means you could review the PR(most) in 24 hours and > give feedback. > > Please reply to this mail in this form. > > *Name, Review Field(agent, backend or both). * > > If this gets passed, and we have reviewers more than 6, I will consider > this as a YES. This list will be shown up on the contributor page[1] as the > reviewer list. > > > [1] > https://github.com/apache/skywalking/blob/master/docs/en/guides/README.md > > > Sheng Wu 吴晟 > > Apache SkyWalking > Apache Incubator > Apache ShardingSphere, ECharts, DolphinScheduler podlings > Zipkin > Twitter, wusheng1108 > -- Hongtao Gao Apache SkyWalking && Apache ShardingSphere Twitter, @hanahmily
