+1, Feel free to do.
———————— Daming(@dmsolr) Apache SkyWalking > 在 2020年2月27日，上午10:47，Sheng Wu <[email protected]> 写道： > > Basically, it is good for me. Have left comments there. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > zhusheng_xu <[email protected]> 于2020年2月27日周四 上午10:41写道： > >> Hi Dev team, >> >> I would like to start a new proposal about actions config changes from >> actions/checkout@v1 to actions/checkout@v2. >> >> >> Sometime skywalking ci and e2e test in github actions will tigger "fatal: >> reference is not a tree”[1] when using actions/checkout@v1. >> Quote form "V2 fetches a specific SHA and retries with a few delays >> between before failing. Whereas V1 fetched the merge PR ref."[2]， >> seem problem above is solved in [email protected] submodule function has >> been removed from V2 version [3]. >> Whether subsequent submodule functions will be added is still unclear [4]. >> >> >> From the official documentation of checkout, there is a way to provide >> submodule functionality through the attachment command line in checkout@v2 >> [5], >> Based on the above reasons, I submitted this PR[6] and all test passed. >> Since I am not familiar with actions/checkout, are there any other >> suggestions and problems? >> Welcome to give some suggestions. >> >> >> [1]https://github.com/actions/checkout/issues/23 >> [2]https://github.com/actions/checkout/issues/23#issuecomment-572688577 >> [3]https://github.com/actions/checkout/issues/81 >> [4]https://github.com/actions/checkout/issues/81#issuecomment-585935021 >> [5]https://github.com/actions/checkout#Checkout-submodules >> [6]https://github.com/apache/skywalking/pull/4419
