Hi,

“Skywalking-agent-test-tool” is good to me. It is so clearly.

The new repo need to link protocol repo. 

> And we are going to use submodule to link this in other repo, right?

We can also use git clone to fetch code. I don’t think submodule is necessary. 
Maybe submodule is good to manage versions.

Anyway, the both of above approaches are good to me.


—————
Daming(@dmsolr)
Apache SkyWalking





> 在 2020年2月28日,上午12:46,吴晟 Sheng Wu <[email protected]> 写道:
> 
> Good to me.&nbsp;
> Which name do we prefer? skywalking-agent-test-tool?
> 
> 
> And we are going to use submodule to link this in other repo, right? No 
> Apache release process for this.
> 
> 
> 
> 
> Sheng&nbsp;Wu&nbsp;吴晟
> 
> From&nbsp;Wu&nbsp;Sheng&nbsp;'s&nbsp;phone.
> 
> 
> 
> ------------------ Original ------------------
> From: apmail-wusheng-owner <[email protected]&gt;
> Date: Thu,Feb 27,2020 10:04 PM
> To: dev <[email protected]&gt;
> Subject: Re: [PROPOSAL]Move the mock collector to a new repo
> 
> 
> 
> Hi the SkyWalking Dev team,
> I write to you to talk about taking the `mock collector`[1] and 
> `validator-tool`[2] to a separated repo as a common tool for agent and plugin 
> testing. 
> They are the common tools to collect records from an agent as OAP. Currently, 
> they are on active service for `Java Agent` and `Nginx-LUA`[3]. As far as I 
> know, PHP Agent and C# Agent are in progress. And The Rust agent is coming 
> soon. Base on those, we propose to move the `mock collector` and 
> `validator-tools` to a new repo as common tools for service all agents. 
> Any suggestion is welcome.
> 
> P.S. The proposal is proposed by @argual in comment[4].
> 
> [1]https://github.com/apache/skywalking/tree/master/test/plugin/mock-collector
> [2]https://github.com/apache/skywalking/tree/master/test/plugin/validator
> [3]https://github.com/apache/skywalking-nginx-lua
> [4]https://github.com/apache/skywalking-nginx-lua/pull/4#issuecomment-591270752
> 
> 
> —————
> Best regards,
> &nbsp;&nbsp;&nbsp; Daming(@dmsolr)
> Apache SkyWalking

Reply via email to