Hi Dev Team, The skywalking-nginx-lua has finished adapting the new v3 protocol[1]. Thank Sheng Wu, Wen Ming, and YuanSheng Wang to review the code.
[1] https://github.com/apache/skywalking-nginx-lua/pull/30 Sheng Wu <[email protected]> 于2020年4月8日周三 下午8:49写道： > han liu <[email protected]> 于2020年4月8日周三 下午8:44写道： > > > Hi Dev Team, > > > > I upgraded skywalking-nginx-lua to protocol v3[1] and it seems working > > well. Also, I have finished the lua e2e test in the local environment. > > I'm still waiting for the Nginx PR review finish, then I can commit the > e2e > > > > Wen Ming > > I will leave you to make the call about that PR. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > > files into the main repo. > > > > [1] https://github.com/apache/skywalking-nginx-lua/pull/30 > > > > Sheng Wu <[email protected]> 于2020年4月8日周三 下午6:42写道： > > > > > Great. Very appreciated for the quick update. > > > > > > Wei Zhang <[email protected]>于2020年4月7日 周二下午9:26写道： > > > > > > > Hi Dev Team, > > > > > > > > I upgraded go2sky to protocol v3[1] and it seems to be working well > so > > > > far[2], then I will check the details. > > > > > > > > [1]: https://github.com/SkyAPM/go2sky/pull/53 < > > > > https://github.com/SkyAPM/go2sky/pull/53> > > > > [2]: https://github.com/SkyAPM/go2sky/pull/53#issuecomment-610384191 > < > > > > https://github.com/SkyAPM/go2sky/pull/53#issuecomment-610384191> > > > > -- > > > > > > > > Wei Zhang 张伟 > > > > Github, @arugal > > > > > > > > > > > > Daming <[email protected]> 于2020年4月7日周二 下午8:23写道： > > > > > > > > > > > > > > Hi, > > > > > It is good to me to remove the InfluxDB storage E2E Test. > > > > > I will make it adapt to the new protocol and restore it. After the > PR > > > > > merged. > > > > > > > > > > > > > > > ————— > > > > > Daming(@dmsolr) > > > > > Apache SkyWalking > > > > > > > > > > > > > > > > > > > > > 在 2020年4月7日，下午2:56，Sheng Wu <[email protected]> 写道： > > > > > > > > > > > > Haochao Zhuang, Zhenxu Ke, Yanlong He and Han Liu > > > > > > > > > > > > I just adjusted the following things in PR tests > > > > > > 1. Remove influxdb storage, lua agent and PHP agent from e2e > tests. > > > > Once > > > > > > you have done in your side, please restore these, we stil expect > > > these > > > > in > > > > > > 8.0 release. > > > > > > 2. No need to do a reboot test. Remove it permanently. > > > > > > 3. SkyWalking 6 compatibility tests have been removed > permanently. > > I > > > > > assume > > > > > > no one will release a new 6.9 for v3 protocol, right? If we have, > > > > please > > > > > > let me know. > > > > > > > > > > > > > > > > > > Sheng Wu 吴晟 > > > > > > Twitter, wusheng1108 > > > > > > > > > > > > > > > > > > Daming <[email protected]> 于2020年4月7日周二 下午1:05写道： > > > > > > > > > > > >> > > > > > >> Hi Dev Team, > > > > > >> > > > > > >> Currently, I have upgraded the Agent-Test Tools to protocol v3. > > And > > > it > > > > > is > > > > > >> in service on PluginTests of the main repository[1]. As I know, > > > > > @mrproliu < > > > > > >> https://github.com/mrproliu> have brought it to lua-nginx > > > > > repository[2]. > > > > > >> > > > > > >> [1]:https://github.com/apache/skywalking/pull/4599 < > > > > > >> https://github.com/apache/skywalking/pull/4599> > > > > > >> [2]:https://github.com/apache/skywalking-nginx-lua/pull/30 < > > > > > >> https://github.com/apache/skywalking-nginx-lua/pull/30> > > > > > >> ————— > > > > > >> Daming(@dmsolr) > > > > > >> Apache SkyWalking > > > > > >> > > > > > >> > > > > > >> > > > > > >>> 在 2020年3月31日，上午11:29，Sheng Wu <[email protected]> 写道： > > > > > >>> > > > > > >>> Hi Dev Team > > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > -- > > > Sheng Wu 吴晟 > > > > > > Apache SkyWalking > > > Apache Incubator > > > Apache ShardingSphere, ECharts, DolphinScheduler podlings > > > Zipkin > > > Twitter, wusheng1108 > > > > > >
