It’s a nice-to-have enhancement of the logging in SkyWalking, in my opinion, 
this PR provides a possibility to log in another format, instead of "replacing" 
the patter-based one, the default logs are still pattern based, therefore, the 
overhead is introduced under the condition that the users are aware of it, 
after all, struggling to configure the log collector (logstash, logtail, etc.) 
to parse the unstructured logs is a pain.

Given that we already have shaded the GSON lib in the agent side, I’m +1 to the 
PR


> On Aug 20, 2020, at 11:07, Sheng Wu <[email protected]> wrote:
> 
> Hi Dev team
> 
> We received a pull request, https://github.com/apache/skywalking/pull/5357
> which is trying to add a JSON format log. I want to get feedback from the
> dev team, is this really necessary? And how is this helpful?
> 
> Sheng Wu 吴晟
> Twitter, wusheng1108


Reply via email to