About ThreadPoolExecutor, yes, you can instrument it. But as no change made on the parameter, where do you expect to carry the tracing context(Snapshot)?
Sheng Wu 吴晟 Twitter, wusheng1108 Li BingLong(智能平台) <binglongli217...@sohu-inc.com> 于2021年1月4日周一 下午2:40写道： > How about enhance an Executor(ThreadPoolExecutor or something similar) if > we can not enhance Runnable. > > > > > > > > *发件人**: *Sheng Wu <wu.sheng.841...@gmail.com> > *日期**: *2021年1月4日 星期一 下午2:30 > *收件人**: *"Li BingLong(智能平台)" <binglongli217...@sohu-inc.com> > *抄送**: *"dev@skywalking.apache.org" <dev@skywalking.apache.org> > *主题**: *Re: Cross Thread plugin > > > > First, you could learn what is lambda really in Java :) You will get the > conclusion that is insane :P > > And about enhancing the Runnable, it is also very radical, as it is widely > used in many places, even not in cross-thread scenarios. That is why we > don't want to mass up the whole JVM > > > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > Li BingLong(智能平台) <binglongli217...@sohu-inc.com> 于2021年1月4日周一 下午2:13写道： > > Hi! > > I have seen the pr. > https://github.com/apache/skywalking/pull/845 > > Frankly, this plugin is invasive compared to other plugins. > > We must write hard code with RunnableWrapper to use it. > Why not enhance the Runnable class? This way we need to support lambda > expression. > >
