+1 (non-binding)
I checked:
-Digital signature and hashes correct
-LICENSE and NOTICE files exists
-All files have license headers if necessary
-Commit id checked


Best Wishes!
CalvinKirs


On 04/10/2021 11:22,Kai Wan<[email protected]> wrote:
Hi all, my +1

1. New features are tested.
2. .sha files are checked and correct.
3. GPG signatures are signed by Sheng Wu.
4. License header in the source is checked and no binary.
5. Compilation from source tar passed.
6. Commit id checked.

Thanks.

Sheng Wu <[email protected]> 于2021年4月10日周六 上午8:09写道:

My own +1 binding

1. GPG checked
2. sha512 checked
3. no binary in source
4. version correct
5. commit id checked.

Sheng Wu 吴晟
Twitter, wusheng1108


Zhenxu Ke <[email protected]> 于2021年4月10日周六 上午7:34写道:

Hi, my +1 (binding), I've checked

- New main features in 8.5.0 are tested.
- GPG signatures are signed by Sheng Wu.
- Shasums are correct for each .sha file.
- No unexpected binary files in source tar.
- Compilation from source tar passed.
- Commit hash matches the release tag.

On 2021/04/09 15:51:15, Sheng Wu <[email protected]> wrote:
Hi All,
This is a call for vote to release Apache SkyWalking version 8.5.0.

Release notes:

*
https://github.com/apache/skywalking/blob/master/changes/changes-8.5.0.md

Release Candidate:

* https://dist.apache.org/repos/dist/dev/skywalking/8.5.0/
* sha512 checksums
-

908c5a6ea60e1ff744eeb308c8e3ceab71832ef62661d7c18c7e418290e7dc714c7669344a0bf3baa975e5a620ceeaf41288649ed734d00c4f4eced88e5e3ec8
apache-skywalking-apm-8.5.0-src.tgz
-

686383083bc84f24e0954ecd340a9c7190345f8582841954848163e1a545d5947d53e86d3d10c23765311275f74445912fd56af496fab3fdfc9cea7ef7f600e1
apache-skywalking-apm-8.5.0.tar.gz
-

df1216352d8553e201bf05d6fdbffe373bb26fece1944afaa8e567fbabfe828b183eac4350447669284340505867324fc4a21616ccbd5b0d7259a1b20bb4cf97
apache-skywalking-apm-es7-8.5.0.tar.gz

Maven 2 staging repository:

*

https://repository.apache.org/content/repositories/xxxx/org/apache/skywalking/

Release Tag :

* (Git Tag) v8.5.0

Release CommitID :

*

https://github.com/apache/skywalking/tree/88f5264d003ea5123f290b56e3c94cae6a3a73c3
* Git submodule
* skywalking-ui:

https://github.com/apache/skywalking-rocketbot-ui/tree/96cfdc00c0e51e7337d78fe83f9559323d5523a5
* apm-protocol/apm-network/src/main/proto:

https://github.com/apache/skywalking-data-collect-protocol/tree/ce9e4e8bd9e552443cc970df67ee25f17ff0d3b8
*

oap-server/server-query-plugin/query-graphql-plugin/src/main/resources/query-protocol

https://github.com/apache/skywalking-query-protocol/tree/42d6783d8c1a0d0d4c2b28e58dc1f47dd554964e

Keys to verify the Release Candidate :

* https://dist.apache.org/repos/dist/release/skywalking/KEYS

Guide to build the release from source :

*

https://github.com/apache/skywalking/blob/v8.5.0/docs/en/guides/How-to-build.md

Voting will start now (Apr. 9th) and will remain open for at least 72
hours, Request all PMC members to give their vote.
[ ] +1 Release this package.
[ ] +0 No opinion.
[ ] -1 Do not release this package because....

Sheng Wu 吴晟
Twitter, wusheng1108





--
—————————
Kai Wan
GitHub @wankai123

Reply via email to