My apologies, I'll be more diligent about creating/cleaning branches on SkyWalking. The purpose of the branch was to remove the un-documented port *1234 *from the distributed SkyWalking Docker image. I saw it when looking at SkyWalking via Kitematic: [image: Screenshot from 2021-10-11 07-16-45.png]
I was in the process of making the PR when I decided to search SkyWalking for *1234* and got some hits and figured maybe the port was necessary. Are you confirming port *1234 *is necessary? If so, I'll go ahead and delete my branch. If not, I'll progress with this work. On Mon, Oct 11, 2021 at 4:03 AM Sheng Wu <[email protected]> wrote: > Hi Brandon > > I can see you created this new > branch(https://github.com/apache/skywalking/tree/BFergerson-patch-1). > But, there is no pull request created, and from the changes, this > seems not necessary. > > Please confirm the purpose, and remove if this is not planned to the > upstream main branch. > > Notice, this mail has cc'ed the dev mail list. Make sure your reply > keeps it too. > > Sheng Wu 吴晟 > Twitter, wusheng1108 >
