Thanks for your explanation! Best, tison.
Sheng Wu <wu.sheng.841...@gmail.com> 于2022年2月12日周六 07:33写道： > 1. This is generated by cargo package, not tar command. So, Rei keeps it > that way. > 2. It will be there after PMC approval, according to asf policy. > > tison <wander4...@gmail.com>于2022年2月12日 周六上午1:06写道： > > > +1 non-binding > > > > 1. asc checked > > 2. sha512 checked > > 3. cargo build passed and test passed > > 4. tag correct > > 5. license and notice exist > > > > Two questions not blockers: > > > > 1. Why do you name the tarball with the .crate extension? .tar.gz should > be > > fine and intuitive. > > 2. I don't find a crate on https://crates.io/ of this agent. Although > it's > > not required for an Apache release, it should be friendly for Rustacean. > > WDYT? > > > > Best, > > tison. > > > -- > Sheng Wu 吴晟 > > Apache SkyWalking > Apache Incubator > Apache ShardingSphere, ECharts, DolphinScheduler podlings > Zipkin > Twitter, wusheng1108 >
