Hi all, as promised, I've just removed Powermock and migrated all our tests from junit 4 to junit 5 in our main repo[1], also I've verified that the tests can be run successfully in Java 17 with some tweaks, see the commend in the PR.
But please note that, there is still a dependency powermock-reflect left, we cannot remove it because we currently heavily depend on the reflection util `org.powermock.reflect.Whitebox;`, if you search globally for `powermock` this must be the only place occurs, all reviewers please don't approve to merge pull requests that brings Powermock back. Also I'm planning to move our development baseline and even runtime baseline to Java 11, if you have any concern please let me know, of course I'll start up a new thread to discuss that and vote on that. [1] https://github.com/apache/skywalking/pull/10382 > On Jan 31, 2023, at 13:52, kezhenxu94 <kezhenx...@apache.org> wrote: > > Hi all, recently I'm trying to add a plugin to support Spring 6[1], > which has a minimum requirement of Java 17 and Jakarta 9. > > In order to compile our Java agent with the Spring 6 plugin, > we have to set the baseline of the development JDK to 17, > but we still keep the runtime baseline as Java 8 compatible. > > So this should only impact the experience of SkyWalking developer, not > SkyWalking users. > > Another noteworthy thing I did in the pull request[1], is that, > I've removed Powermock completely from skywalking-java repository and > there is no reason we would bring it back in the future. > I'll also try to remove it in the skywalking main repo. > > This is a future-prove work that would block us from upgrading the JDK > baseline to Java 8+, > or upgrading the Junit framework to Junit 5. > > So be careful when you review contributors' pull requests, if they bring > Powermock back, don't approve to merge. > > [1] https://github.com/apache/skywalking-java/pull/444
