kezhenxu94 commented on PR #5: URL: https://github.com/apache/skywalking-terraform/pull/5#issuecomment-1586478834
https://github.com/apache/skywalking-terraform/pull/3#pullrequestreview-1471045760 > we can also add a variable to switch whether creating the key pair or not, this can be especially useful for new installation Hi sorry, looks like I didn't make myself clear in that comment, what I meant is to add a task that creates the key pair for the users, so that users don't have to create the key pair by themself before they can use our Terraform module, specifically, what I'm proposing is to add something like this: ``` resource "tls_private_key" "skywalking" { algorithm = "RSA" rsa_bits = 4096 } ``` and use that public key to create the AWS machines and use the private key to connect to the machine in Ansible playbook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
