kezhenxu94 commented on code in PR #12:
URL:
https://github.com/apache/skywalking-terraform/pull/12#discussion_r1278674698
##########
ansible/roles/skywalking/vars/main.yml:
##########
@@ -15,3 +15,10 @@
---
skywalking_version: "9.5.0"
+sw_server_port: "8080"
+sw_oap_server_port: 12800
+
+env_vars:
+ SW_SERVER_PORT: "{{ sw_ui_server_port }}"
+ SW_OAP_ADDRESS: "{{ hostvars[groups['skywalking-oap'][0]].ansible_host }}:{{
sw_oap_server_port }}"
Review Comment:
Some hints:
- We can configure multiple addresses here when in cluster mode, e.g,
http://1.2.3.4:12800,http://1.2.3.5:12800
- We need `http://` prefix for each of the OAP addresses, e.g.,
http://1.2.3.4:12800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
