+1 binding 1. .sha512 files are checked. 2. GPG signatures are signed by Han Liu <liu...@apache.org>. 3. LICENSE and NOTICE exist. 4. Make build passed. 5. Tag correct.
————————— Kai Wan GitHub @wankai123 Sheng Wu <wu.sheng.841...@gmail.com> 于2024年2月21日周三 23:35写道： > > +1 binding > > 1. Version correct > 2. Tag checked. > 3. All key changes listed in the change logs. > 4. Compiling passed > 5. asc checked. > 6. sha exists > > One nit, the year of NOTICE(2 places) is not updated, I fixed it through > - https://github.com/apache/skywalking-go/pull/172 > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > han liu <liu...@apache.org> 于2024年2月21日周三 14:31写道： > > > > Hi the SkyWalking Community: > > This is a call for vote to release Apache SkyWalking Go version 0.4.0. > > > > Release notes: > > > > * https://github.com/apache/skywalking-go/blob/v0.4.0/CHANGES.md > > > > Release Candidate: > > > > * https://dist.apache.org/repos/dist/dev/skywalking/go/0.4.0 > > * sha512 checksums > > - > > b8ad384bbc682f373bac62879b92dd5601e26bd090669ce02b4cb02463497fd913e0e6eba96c1cc0b66e0de49970abdee7d261f182602ea5a9dedad3a31a059d > > apache-skywalking-go-0.4.0-bin.tgz > > - > > 318f2283f33d3e362955cf0b69a44387feaf036d5ffcaa49f12bd720317901d043d76890733e43a099d4e5fa2b81648079988c92d8ef8821718bae9c7246c1b1 > > apache-skywalking-go-0.4.0-src.tgz > > > > Release Tag : > > > > * (Git Tag) v0.4.0 > > > > Release Commit Hash : > > > > * > > https://github.com/apache/skywalking-go/tree/642606007162e9b6f5c6827e4903994f6364d8fe > > > > Keys to verify the Release Candidate : > > > > * https://dist.apache.org/repos/dist/release/skywalking/KEYS > > > > Guide to build the release from source : > > > > * > > https://github.com/apache/skywalking-go/blob/v0.4.0/docs/en/development-and-contribution/how-to-release.md > > > > Voting will start now and will remain open for at least 72 hours, all > > PMC members are required to give their votes. > > > > [ ] +1 Release this package. > > [ ] +0 No opinion. > > [ ] -1 Do not release this package because.... > > > > Thanks. > > > > [1] > > https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-release.md#vote-check
