+1 binding - asc checked - sha512 exist - compiling passed on the MacOS - version correct - download link correct - tag correct on GH.
Two nits, 1. With skywalking-eye check, there is an error due to lack of header of VERSION file ``` INFO Loading configuration from file: .licenserc.yaml INFO Totally checked 553 files, valid: 402, invalid: 1, ignored: 150, fixed: 0 INFO GITHUB_TOKEN is not set, license-eye won't comment on the pull request ERROR the following files don't have a valid license header: VERSION ERROR one or more files does not have a valid license header ``` It doesn't matter as this is just a generated VERSION file. But it is in the git ignore file, but doesn't ignore through skywalking-eye ignore file. 2. The link in the main seems not necessarily, as it is from main repo, which mostly is a Java project. > [1] > https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-release.md#vote-check This PR should fix this issue, https://github.com/apache/skywalking-go/pull/195 Sheng Wu 吴晟 Twitter, wusheng1108 han liu <liu...@apache.org> 于2024年8月21日周三 12:25写道： > > Hi the SkyWalking Community: > This is a call for vote to release Apache SkyWalking Go version 0.5.0. > > Release notes: > > * https://github.com/apache/skywalking-go/blob/v0.5.0/CHANGES.md > > Release Candidate: > > * https://dist.apache.org/repos/dist/dev/skywalking/go/0.5.0 > * sha512 checksums > - > 20b26c57873788c8368fa0c7d672c4d76ecedd8ba4367b752dd2030c8e15496875eb01a1b397749dbbc1316c7556e2561c2226863de5cdf78604a26d1b9df92b > apache-skywalking-go-0.5.0-bin.tgz > - > a389808d0615e3f67e47caee63f503bcbe5f19e4ad15d1ee7dc64fd1ca4639fcc6014e392a6997f25a8947258d07db7de9d0f8db253efaa6ee3ea093e02b7101 > apache-skywalking-go-0.5.0-src.tgz > > Release Tag : > > * (Git Tag) v0.5.0 > > Release Commit Hash : > > * > https://github.com/apache/skywalking-go/tree/c997106bb789c57c9f6375d9324805eab02856b4 > > Keys to verify the Release Candidate : > > * https://dist.apache.org/repos/dist/release/skywalking/KEYS > > Guide to build the release from source : > > * > https://github.com/apache/skywalking-go/blob/v0.5.0/docs/en/development-and-contribution/how-to-release.md > > Voting will start now and will remain open for at least 72 hours, all > PMC members are required to give their votes. > > [ ] +1 Release this package. > [ ] +0 No opinion. > [ ] -1 Do not release this package because.... > > Thanks. > > [1] > https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-release.md#vote-check
