Thorbjørn Ravn Andersen skrev: > Ceki Gulcu skrev den 03-10-2008 21:53: > >> Are there any remaining tasks? Thorbjørn is still working on agent >> instrumentation. Ralph has volunteered to add documentation about XLogger. >> The >> >> > I think the agent instrumentation should not be announced until it is > ready. In that regard I am quite interested in seeing what Real-World > Code Ralph can throw at it :) > > Hi Ceki.
I have spent quite some time figuring out how to handle logging with object parameters with rogue toString() implementations and have found it too hard for me to get right in code, so I have delegated it to the developer using it to exclude these classes from the logging configuration (cheap, but works) by saying so in the documentation. > Also, it is a problem that unless explicitly told not to, also JRE > classes are instrumented. I have considered adding an origin check so > that you can disable/enable instrumentation based on which jar it comes > from. Was the stuff you added lately to identify the jar from the > patch, hard to work with? > I also found a solution to this problem. Basically it is "only instrument a class if the slf4j API classes are available to it" - that has turned out to work well for my real-life situations. Also it is now robust against objects throwing exceptions when being toString'ed, as well as being able to show nested arrays of both objects and primitives. It has taken quite some time but I finally now has this in a state where it will work with the multi-threaded real-life legacy applications I have at work, so unless you hear otherwise I would like to have it announced in the next release of slf4j. I would appreciate your help in getting the jar file names right in the created manifest when you have the time. I currently hard code them but it would be very nice if they could be extracted from the dependencies section. -- Thorbjørn Ravn Andersen "...plus... Tubular Bells!" _______________________________________________ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
