[
https://issues.apache.org/jira/browse/SLIDER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007025#comment-14007025
]
Steve Loughran commented on SLIDER-103:
---------------------------------------
# yes, we do want to pull a lot of the logic out from the client into a lower
layer -it's been in the plan, but refactoring the client hasn't completed.
Ideally the client would just the CLI way to access the classes that do the
work.
# a lot of that console output comes from the layers underneath -it will
happen. That specific action {{exists()}} does do some extra chattiness
# most of the Action operations return exceptions, exceptions that *contain
exit codes*. The interface {{ExitCodeProvider}} exists to allow exit codes to
be extracted from exceptions (irrespective of their parent class), the service
launcher uses these to generate responses from the main() method. By raising
exceptions, direct callers of the API can not only get back a number, they get
back a stack trace and text -which are things we test for. Trying to switch
back to a simple exit code in the operation would be a regression that would
hurt diagnostics
# there's already been a lot of work trying to return distinct exit codes for
different states, with {{org.apache.slider.common.SliderExitCodes}} covering
them. If that isn't enough, we can add some more.
> SliderClient action methods need to be refactored to be API friendly
> --------------------------------------------------------------------
>
> Key: SLIDER-103
> URL: https://issues.apache.org/jira/browse/SLIDER-103
> Project: Slider
> Issue Type: Task
> Components: client
> Affects Versions: Slider 0.30
> Reporter: Srimanth Gunturi
> Fix For: Slider 0.40
>
>
> From Ambari Slider View I wanted to know if an app is frozen. Only available
> method available is {{SliderClient.actionExists()}} - which always writes to
> the console. We need API friendly methods which will return values.
> Similar need exists for all the {{SliderClient.action*()}} methods.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
