[ 
https://issues.apache.org/jira/browse/SLIDER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068046#comment-14068046
 ] 

ASF subversion and git services commented on SLIDER-228:
--------------------------------------------------------

Commit b2f8354d606f08584ab100317fd3ccff8e260665 in incubator-slider's branch 
refs/heads/develop from [~elserj]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;h=b2f8354 ]

SLIDER-228 Lift maven-compiler-plugin definition to pluginManagement and add 
enforcer plugin to verify minimum jdk

We set the groovy-eclipse-compiler on the maven-compiler-plugin to get 
compilation of both java
and groovy files. It doesn't appear that the groovy-eclipse-compiler will fail 
when the target
JDK version is different than the actual version of java on the system (like 
the default compiler
used by the maven-compiler-plugin does).

Sets up an enforcer plugin rule that asserts the JDK minimum version instead of 
relying
on the compiler plugin to appropriately warn the user when <1.7 is used.


> Set up enforcer plugin to assert that JDK7 is used to build project
> -------------------------------------------------------------------
>
>                 Key: SLIDER-228
>                 URL: https://issues.apache.org/jira/browse/SLIDER-228
>             Project: Slider
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: Slider 0.40
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: Slider 0.50
>
>         Attachments: 
> 0001-SLIDER-228-Lift-maven-compiler-plugin-definition-to-.patch
>
>
> In testing out 0.40.0, I got some compilation failures because I happened to 
> build on a VM that still had JDK6 installed.
> We can easily set up the maven-enforcer-plugin to fail the build when <JDK7 
> is used.
> I'll do this for 0.50, but if we happen to make another 0.40 RC, we could 
> easily pull this in for 0.40.0.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to